Roy Golan has posted comments on this change.

Change subject: core: Inject Task schedulers instead of JNDI lookups
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/41035/4/backend/manager/modules/scheduler/pom.xml
File backend/manager/modules/scheduler/pom.xml:

Line 7:     <version>3.6.0-SNAPSHOT</version>
Line 8:   </parent>
Line 9: 
Line 10:   <artifactId>scheduler</artifactId>
Line 11:   <packaging>jar</packaging>
> As this becomes a plain .jar now I'd suggest that you create a JBoss module
I want to avoid the modules bug, so that's the quickest I can go. are you fine 
with postponing the move to module till we move to wildfly?
Line 12: 
Line 13:   <name>engine scheduler bean</name>
Line 14:   <properties>
Line 15:     <engine.db>pgsql</engine.db>


-- 
To view, visit https://gerrit.ovirt.org/41035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2288d0bd0584c7ba17f3dabaff268e40cbdddbea
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to