Roy Golan has posted comments on this change. Change subject: core: Inject Task schedulers instead of JNDI lookups ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/41035/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java: Line 191: public void initialize() { Line 192: log.info("Start initializing {}", getClass().getSimpleName()); Line 193: // start task schedulers Line 194: for (SchedulerUtil taskScheduler : taskSchedulers) { Line 195: log.info("Started task scheduler {}", taskScheduler); > This is a bit confusing, the code does nothing but send the log message. Co agree. will add Line 196: } Line 197: // initialize configuration utils to use DB Line 198: Config.setConfigUtils(new DBConfigUtils()); Line 199: // we need to initialize os-info before the compensations take place because of VmPoolCommandBase#osRepository https://gerrit.ovirt.org/#/c/41035/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/di/qualifier/InMemory.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/di/qualifier/InMemory.java: Line 1: package org.ovirt.engine.core.di.qualifier; Line 2: Line 3: import javax.inject.Qualifier; Line 4: Line 5: @Qualifier > Consider to explicitly indicate the @Retention and @Target. Yes I missed it. I added it but for some reason weld refused to detect it on the Singleton beans. so I dropped it altogether in the next patch set Line 6: public @interface InMemory { https://gerrit.ovirt.org/#/c/41035/4/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java File backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java: Line 86: * @return a {@code DBSchedulerUtilQuartzImpl} instance Line 87: */ Line 88: @Deprecated Line 89: public static SchedulerUtil getInstance() { Line 90: return instance; > Take into account that is potentially very dangerous. You are saving a refe I left the getInstance as for first step to get the code in and not create a huge patch changing that. If its not lots of files I'll include that Line 91: } Line 92: Line 93: /** Line 94: * To avoid data serialization issues for jobdata that is persisted in the database inputParams should be of -- To view, visit https://gerrit.ovirt.org/41035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2288d0bd0584c7ba17f3dabaff268e40cbdddbea Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
