Moti Asayag has posted comments on this change. Change subject: core: Use ToStringBuilder in sla classes ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39981/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java: Line 139: Line 140: } Line 141: Line 142: @Override Line 143: public String toString() { > so instead of polimorphic build just create a string builder here and the s Roy, with "super.toString() + new ToStringBuilder..." we leave the decision how to format the output to the hands of each class which we'd like to avoid for the sake of uniformity. This led us to a place where there is an endless formats of the toString() method, based on the developer preferences. I'd like to avoid it and to reduce the amount of divergence in the code. Line 144: return appendAttributes(ToStringBuilder.forInstance(this)).build(); Line 145: } -- To view, visit https://gerrit.ovirt.org/39981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ed7b26ec4fbade8b1f63aaa7138de4e6ce49937 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
