Roy Golan has posted comments on this change. Change subject: core: Use ToStringBuilder in sla classes ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39981/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/ProfileBase.java: Line 8: import org.ovirt.engine.core.common.businessentities.BusinessEntitiesDefinitions; Line 9: import org.ovirt.engine.core.common.businessentities.BusinessEntity; Line 10: import org.ovirt.engine.core.common.businessentities.IVdcQueryable; Line 11: import org.ovirt.engine.core.common.businessentities.Nameable; Line 12: import org.ovirt.engine.core.common.utils.ToStringBuilder; I'm not against ToStringBuilder but I rather have less methods and not more. Line 13: import org.ovirt.engine.core.common.validation.annotation.ValidName; Line 14: import org.ovirt.engine.core.common.validation.group.CreateEntity; Line 15: import org.ovirt.engine.core.common.validation.group.RemoveEntity; Line 16: import org.ovirt.engine.core.common.validation.group.UpdateEntity; Line 139: Line 140: } Line 141: Line 142: @Override Line 143: public String toString() { so instead of polimorphic build just create a string builder here and the sub-classes will append it so say the CpuProfile: toString() super.toString() + new ToStringBuilder... Line 144: return appendAttributes(ToStringBuilder.forInstance(this)).build(); Line 145: } -- To view, visit https://gerrit.ovirt.org/39981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ed7b26ec4fbade8b1f63aaa7138de4e6ce49937 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
