Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/37886/18/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 52: public Map<String, Object> parse(String[] args) throws Exception { Line 53: return parse(new ArrayList<String>(Arrays.asList(args))); Line 54: } Line 55: Line 56: public Map<String, Object> parse(List<String> args) throws Exception { > why do these two need to throw exception? if something wrong? not sure I follow. anyway, refer to my comment from Apr 7 01:16, I suggest not to throw exception but return throwable or defer exception so that caller can review partial args as well. Line 57: List<Object> others = new ArrayList<>(); Line 58: Map<String, Object> argMap = new HashMap<>(); Line 59: args.addAll(0, defaults); Line 60: -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ondra Machacek <[email protected]> Gerrit-Reviewer: Ondřej Macháček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
