Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 18: (1 comment) > (1 comment) > > This classes would be more usable to me if they would only throw > exception if something goes wrong, and not if parsing fails. > maybe return response containing args, status, msg and drop > ExitException (or always return map and have them as keys in map) > > Up to you two.. yes, see my last notes, and write what you think https://gerrit.ovirt.org/#/c/37886/18/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParserArgument.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParserArgument.java: Line 11: private Pattern matcher; Line 12: private Class<?> convert; Line 13: private boolean mandatory; Line 14: private String metavar; Line 15: private boolean mutivalue; > mutivalue => multivalue oh! this is clearer. Line 16: Line 17: public ParserArgument() {} Line 18: Line 19: public String getName() { -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ondra Machacek <[email protected]> Gerrit-Reviewer: Ondřej Macháček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
