On Jul 25, 2019, at 7:34 AM, John Mattsson <john.matts...@ericsson.com> wrote:
> 
> Minor comments on the 01 version. Otherwise I think the document is ready for 
> WGLC.

  Thanks.

> - I agree with Mohit that the title should be changed to something like
> "EAP Session-Id Derivation for EAP-SIM, EAP-AKA, and PEAP"

  Done.

> - Abstracts in RFCs cannot have references. [RFC5247] and [AKAP] need to be 
> removed.

  The names still need to be there, I think.  But they shouldn't be references.

> - The following sentences in the abstract and intro will have to change
>  before publishing.
> 
>  "EAP Session-Id derivation has not been defined for EAP-SIM, EAP-AKA,
>  and EAP-AKA' when using the fast re-authentication exchange instead
>  of full authentication."
> 
>  I suggest to just remove EAP-AKA' (The document already talks about 
> RFC5448bis). 
> 
>  "EAP Session-Id derivation has not been defined for EAP-SIM and EAP-AKA,
>   when using the fast re-authentication exchange instead
>   of full authentication."

  Done.

> - The sentence in the abstract about EAP-AKA' should be in the document body 
> as well.
> 
>  "Since [AKAP] defines the Session-ID for EAP-AKA', the definition for
>  EAP-AKA' is not included here."

  Done with some minor word smithing.

> - "TLS 1.2 or earlier is used" -> "TLS 1.2 is used"
> 
>   The TLS wg document draft-ietf-tls-oldversions-deprecate (Submitted to IESG
>       for Publication) formally prohibits negotiation and use of TLS 1.0
>       and TLS 1.1. It also updates all RFCs that use TLS.

  I suppose so. I do suspect, tho, that there are millions of end user devices 
doing EAP which don't support TLS 1.2.

> - "deriviation" -> "derivation"
> 
> - "EAP-SIM, and EAP-AKA" -> "EAP-SIM and EAP-AKA"

  Fixed, thanks.

  Alan DeKok.

_______________________________________________
Emu mailing list
Emu@ietf.org
https://www.ietf.org/mailman/listinfo/emu

Reply via email to