Hi Les, Thanks very much for submitting this bug fix. I have entered your fix, please take a look and let us know if this is what you wanted:
Here's the git commit & diff: http://git.linuxcnc.org/gitweb?p=emc2.git;a=commitdiff;h=4f08abc4f36c3bfdb25faacc5167745b751cec37 Here's the raw file (../src/hal/classicladder/protocol_modbus_master.c) http://git.linuxcnc.org/gitweb?p=emc2.git;a=blob_plain;f=src/hal/classicladder/protocol_modbus_master.c;hb=4f08abc4f36c3bfdb25faacc5167745b751cec37 Chris Radek has put this into 2.4_branch and 2.5_branch, so it will show up in current releases fairly soon, please be patient. Thanks, Kim On 03/27/2011 11:44 AM, Les Newell wrote: > ClassicLadder had a bug in it's Modbus implementation if you read more > than 8 inputs or coils. The first input bit is not read correctly and > ends up with strange values. > I don't know the correct way to submit a fix using Git but the fix is > simple. In protocol_modbus_master.c, a break; needs to be inserted in > line 321. Currently it falls through to the next case. > > Les > > ------------------------------------------------------------------------------ > Enable your software for Intel(R) Active Management Technology to meet the > growing manageability and security demands of your customers. Businesses > are taking advantage of Intel(R) vPro (TM) technology - will your software > be a part of the solution? Download the Intel(R) Manageability Checker > today! http://p.sf.net/sfu/intel-dev2devmar > _______________________________________________ > Emc-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/emc-users > > ------------------------------------------------------------------------------ Enable your software for Intel(R) Active Management Technology to meet the growing manageability and security demands of your customers. Businesses are taking advantage of Intel(R) vPro (TM) technology - will your software be a part of the solution? Download the Intel(R) Manageability Checker today! http://p.sf.net/sfu/intel-dev2devmar _______________________________________________ Emc-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-users
