Jacob Gerlach <jacobgerl...@gmail.com> writes:
> Patch attached for fuzzy links.
Thank you.
> I don't really use code blocks, so I wasn't sure what to do with
> org-export-resolve-coderef. Should the final
>
> (when (re-search...
> (cond ...
>
> become
>
> (or (re-search...
> (cond ...
> (error
No, the whole body could be wrapped with an `or':
(or (org-element-map ...)
(user-error "Unable to resolve code reference: %s" ref))
> ID links are tricky. AFAICT, an invalid id link will always resolve to
> the file it's contained in. The last check in
> org-export-resolve-id-link is looking for the id in `:id-alist'. Is
> this the same `:id-alist' built in org-export-get-environment?
Yes, it is.
> If so, is it desirable for org-id-find-id-file to fall back on the
> current buffer (the current behavior)?
According to its docstring, `org-id-find-id-file' returns nil when
search failed. Isn't it the case?
> I don't know the implications of changing org-id-find-id-file. The
> fall back behavior was introduced in ac83bc01 when org-id was mostly
> rewritten. Removing the fall back behavior doesn't cause any failures
> on `make test'. If it's acceptable to remove the fall back, I can
> provide a similar patch for org-export-resolve-id-link.
`org-export-resolve-id-link' could throw an error, indeed.
> Subject: [PATCH] ox.el: Issue error for unresolved fuzzy link
>
> * lisp/org-capture.el (org-export-resolve-fuzzy-link): throw error
^^^^^^^^^^^
wrong file
You need to capitalize sentence: "Throw an error"
> instead of returning nil when link can't be resolved.
>
> * testing/lisp/test-ox.el (test-org-export/resolve-fuzzy-link): change
> last test from should-not to should-error
Ditto.
> + ;; No destination found: error.
> + (unless match-title-p
> + (error (format "Unable to resolve link \"%s\"" raw-path)))))))))
You don't need to check `match-title-p' here. Also, it should be
`user-error' instead of `error'.
Regards,
