Eric Abrahamsen <e...@ericabrahamsen.net> writes:
> Undeterred by my previous bum patch, I'm sending more patches!
>
> Most of these are "what do you think" patches.
>
> 1. Ensure-org-log-into-drawer-returns-nil-or-string
>
> If the answer to my last question is "make sure `org-log-into-drawer'
> never returns just t", then this patch does that. If that isn't the
> answer, something can be done with `org-log-beginning'.
Nope, I just shouldn't be posting patches today. One should not code
while hungover. Fixed patch attached.
>From c99d6065ae25d927a395f9aed611fab22b8e40c9 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <e...@ericabrahamsen.net>
Date: Sun, 14 Dec 2014 17:31:49 +0800
Subject: [PATCH 1/4] Ensure org-log-into-drawer returns nil or string
* lisp/org.el (org-log-into-drawer): Don't let it simply return t.
---
lisp/org.el | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index 4aa7988..db5810d 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -2969,7 +2969,11 @@ If the current entry has or inherits a LOG_INTO_DRAWER property, it will be
used instead of the default value."
(let ((p (org-entry-get nil "LOG_INTO_DRAWER" 'inherit t)))
(cond
- ((not p) org-log-into-drawer)
+ ((not p)
+ (when org-log-into-drawer
+ (if (stringp org-log-into-drawer)
+ org-log-into-drawer
+ "LOGBOOK")))
((equal p "nil") nil)
((equal p "t") "LOGBOOK")
(t p))))
--
2.1.3
> 2. Missing-comma-in-org-agenda-with-point-at-orig-entry
>
> The (currently unused) macro `org-agenda-with-point-at-orig-entry' is
> missing a comma.
>
> 3. New-function-org-get-log-list and
> New-function-org-agenda-show-log-item
>
> This is the "what do you think part". The first patch finds and returns
> the state log items of the current entry, as a list of parsed elements.
> It probably doesn't try hard enough to make sure it's really found the
> list.
>
> The second implements an Agenda command which displays the text of the
> most recent note on the entry under point. I use logging a lot, and am
> forever looking at "WAIT" or "NEXT" todos, and wondering what the heck I
> was waiting for, or actually supposed to do next.
>
> If this is acceptable in principle, the finished product would probably
> be a normal org-mode function, with an Agenda implementation on top of
> that, and maybe some sort of guard against displaying overly-long notes.
>
> Alternately, I could probably make this into something akin to
> org-agenda-entry-text-mode, where *all* entries have their most recent
> log item stuck under them. I find that sort of thing distracting, but
> some people might like it.
>
> WDYT?
>
> Eric
