Rasmus writes: >> Could you please rebase or cherry-pick your changes onto the >> then-current master before committing them? > > Yes, I am very happy to! > > However, can you please elaborate on what exactly I did wrong? I have > checked for the following to understand your criticism: > > 1. When I do $ git diff 004332b^ 00433b I get a one line diff (except > the context). There are no change of white space or other garbage. > Why is this not cherry-picked? […]
This one is, but your earlier commits introduced half a dozen spurious merges since they were all started at different points on master. > In principal it is true. However, is it a real issue¹ in practice? The script that generates the ChangeLog for the Emacs merge will list all of these separately and Bastien or who else is doing the merge will have to manually put them back together. > ¹ It pains me every time I use my private email for public mailing > list, but I doubt you had my privacy in mind? I was asking no such thing, only that the author name and email you use for your commits are always one and the same. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2: http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
