Achim Gratz <strom...@nexgo.de> writes:

> schulte.e...@gmail.com writes:
>> I think this change could make it easier to reproduce problems with
>> Org-mode loaded and without the user's personal config loaded.
>
> So you want $(BATCH) with "-batch" filtered out?  

Essentially.

> You can do that without the code duplication.
>

Ah, I had no idea.  I see now that the filter-out command does just
this.  I'm consistently surprised at the depth of the Makefile tooling.

>
>> +      --eval '(setq org-babel-load-languages \
>> +              (quote ($(foreach ob-lang,$(BTEST_OB_LANGUAGES) emacs-lisp sh 
>> org,$(lst-ob-lang)))) \
>> +      )' \
>> +      -l org-loaddefs.el -l cl -l org -l ox -f org-version
>
> These are specifically needed for batch testing.  I wouldn't want to
> load all of these for a minimal Emacs.
>
>> +.PHONY: minimal
>> +vanilla:
>
> Does not match (minimal<=>vanilla) and targets don't belong in
> default.mk.
>

Okay, this last point was just a bug, I changed the name part way
through.

I've cleaned up this patch per your suggestions and just pushed a better
version up.

Thanks for the feedback,

>
>
> Achim.

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D

Reply via email to