On Mon, Sep 23, 2013 at 11:16:25AM +0200, Sebastien Vauban wrote: > Hello Suvayu, > > Suvayu Ali wrote: > > On Mon, Sep 23, 2013 at 10:51:33AM +0200, Nicolas Richard wrote: > >> Carsten Dominik <[email protected]> writes: > >> > >> > Applied > >> > >> I noticed that the whole mail went into the commit msg (commit > >> 12de6223dcd736c0958eca874def052b407ff5d1) ; did I send the patch > >> incorrectly ? > >> > >> I used git format-patch then inserted the result at the end of the email > >> I wrote. The page http://orgmode.org/worg/org-contribute.html#sec-4 is > >> not very explicit about how to send the result of `git format-patch', > >> but I seem to remember it was ok to just yank the content at the end of > >> a mail. Is that a wrong assumption ? > > > > Simply attaching the patch as a text attachment should do fine I think. > > Though, many guidelines tell: > > Do not attach your patch, but submit it "inline" in the mail body, > /unless you cannot teach your mailer to leave the formatting > of the patch alone/. > > That allows for easy reviews... and easy comments (after every chunk of code).
Valid point. In that case maybe the problem was Nicolas's patch was inlined after the signature marker, "-- ". -- Suvayu Open source is the future. It sets us free.
