Achim Gratz <strom...@nexgo.de> writes: > Aaron Ecay writes: >> * lisp/ob-core.el (org-babel-check-confirm-evaluate): remove >> (org-babel-check-evaluate), >> (org-babel-confirm-evaluate): move logic here >> >> This macro is used in only two places, and has two almost-independent >> complex logics coded into it. So, suppress the macro and move the logic >> into the respective functions. > > I have recently introduced that macro because no amount of documentation > can guarantee that the two functions using these values compute them the > same way when somebody makes further changes down the road. That is, > however, mandatory for these functions to work properly and safely. > > I haven't checked if the logic hasn't changed with that patch, but I > don't think it's any easier to understand than before. >
I agree with Achim, I think we should retain the macro. Best, -- Eric Schulte http://cs.unm.edu/~eschulte
