Noorul Islam Kamal Malmiyoda <noo...@noorul.com> writes: > Not necessary this time.
Okay, thanks. I amended http://orgmode.org/worg/org-contribute.html to explain why patches made with `git format-patch' are always preferred, even small patches. I'm less and less using Patchwork as a way to apply patches, because I find commit messages to be sometimes messy that way. Instead, I have local folders with patches I want to apply/review/etc. I patch Org using `git apply' when I want to test, `git am' when I want to commit a properly formatted patch. It means that for each patch that doesn't have a ChangeLog, I have to (1) add it myself and (2) manually use git commit --author="<author>" to have the correct author displayed. To summarize, whether the patch is *small or big* is not the right criterium to decide whether a simple `git diff' is acceptable -- it's more about whether the patch is sent for testing purpose first, or whether it is considered applicable as such. Thanks! -- Bastien
