Eric Schulte <schulte.e...@gmail.com> writes:
> Matt Lundin <m...@imapmail.org> writes:
>
>> Hi Eric,
>>
>> Eric Schulte <schulte.e...@gmail.com> writes:
>>
>>> I just pushed up a fix for this issue.
>>>
>>> Thanks for suggesting this change. -- Eric
>>
>> This fix broke org-bibtex-fleshout, since org-babel-trim converts nil to
>> "". As a result, org-bibtex-fleshout believes that there are values for
>> all the required fields even though those fields are not defined.
>>
>
> Oh, thanks for catching this Matt, I've just pushed up a fix.
Thanks!
While we're on the subject of org-bibtex, I'm attaching a patch to fix
the tagging functionality I added a while back.
Best,
Matt
>From c935b2afcd7cf673fff15efd9766f2d081289358 Mon Sep 17 00:00:00 2001
From: Matt Lundin <m...@imapmail.org>
Date: Mon, 18 Jul 2011 12:37:20 -0500
Subject: [PATCH] Fix argument to org-toggle-tag.
* lisp/org-bibtex.el: (org-bibtex-create, org-bibtex-write): Change
argument of org-toggle-tag to 'on. (Other arguments, e.g., t, have
no effect).
---
lisp/org-bibtex.el | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/org-bibtex.el b/lisp/org-bibtex.el
index 6536917..165e96f 100644
--- a/lisp/org-bibtex.el
+++ b/lisp/org-bibtex.el
@@ -555,7 +555,7 @@ If nonew is t, add data to the headline of the entry at point."
(org-bibtex-put "TITLE" title)))
(org-bibtex-put "TYPE" (substring (symbol-name type) 1))
(org-bibtex-fleshout type arg)
- (mapc (lambda (tag) (org-toggle-tag tag t)) org-bibtex-tags)))
+ (mapc (lambda (tag) (org-toggle-tag tag 'on)) org-bibtex-tags)))
(defun org-bibtex-create-in-current-entry (&optional arg)
"Add bibliographical data to the current entry.
@@ -594,7 +594,7 @@ This uses `bibtex-parse-entry'."
(let ((entry (pop *org-bibtex-entries*))
(org-special-properties nil)) ; avoids errors with `org-entry-put'
(flet ((val (field) (cdr (assoc field entry)))
- (togtag (tag) (org-toggle-tag tag t)))
+ (togtag (tag) (org-toggle-tag tag 'on)))
(org-insert-heading)
(insert (val :title))
(org-bibtex-put "TITLE" (val :title))
--
1.7.6
