Tassilo Horn <tass...@member.fsf.org> wrote:
> > Nevertheless, when I insert foo, the icon is shown, but when I insert
> > bar, the icon is an empty box. What am I missing?
>
> I have a similar problem. In one of my org files, I have
>
> %%(org-google-weather "Montabaur" "de")
>
> and since lately, I get only squares.
>
> That said, while trying your example, `org-google-weather' always
> returned nil. The reason is that I don't have
> `org-google-weather-location' set explicitly to something different as
> the default value. But that default is a form and it is never evaluated
> AFAICS. So that seems to be another bug.
>
> Ok, so when I change your testcase to this...
>
> --8<---------------cut here---------------start------------->8---
> (defun foobar ()
> (interactive)
> (let ((date '(6 6 2011)))
> (setq bar (org-google-weather "Montabaur" "DE"))
> (setq foo (let ((org-google-weather-cache-time 0))
> (org-google-weather "Montabaur" "DE")))
> (string= foo bar)
> (insert foo)
> (insert bar)))
> --8<---------------cut here---------------end--------------->8---
>
> I get an error at the foo value evaluation. The evaluation of bar seems
> to work fine...
>
> --8<---------------cut here---------------start------------->8---
> Debugger entered--Lisp error: (error "Data not found")
Yes, the "Data not found" problem is an org-google-weather problem,
I sent Julien the following patch - either apply it by hand or
check Julien's git repo: it may be there already.
--8<---------------cut here---------------start------------->8---
diff --git a/org-google-weather.el b/org-google-weather.el
index 3ff0aa3..02db878 100644
--- a/org-google-weather.el
+++ b/org-google-weather.el
@@ -70,6 +70,7 @@ Valid %-sequences are:
(defun org-google-weather-get-icon (url)
(with-current-buffer
(google-weather-retrieve-data-raw url org-google-weather-cache-time)
+ (goto-char (point-min))
(unless (search-forward "\n\n" nil t)
(error "Data not found"))
(let ((data (buffer-substring (point) (point-max))))
--8<---------------cut here---------------end--------------->8---
Nick
