On Thu, Jun 2, 2011 at 16:47, Bernt Hansen <be...@norang.ca> wrote:
> Michael Brand <michael.ch.br...@gmail.com> writes:
>> Can I remove this substitution of "release_7.5-350-g3433" ->
>> "release_7.5.350.g3433" from org-version in my patch or should "make
>> info_git_describe" do the same and why?
>
> Hi Michael,
>
> This was purely cosmetic.  I didn't like the look of the mixed '.' and
> '-' in the version number originally.

... and '_' ... :-)

> I think the two reported version
> numbers should be consistent between the org-version function and the
> documentation version function you are proposing.
>
> If you want to remove the substitution please also do so in the
> org-version code so the reported numbers are consistent.

Since I would like to give the more often used "git describe"
precedence I will make org-version and "make info_git_describe"
consistent with git. The ".dirty" postfix of org-version I will leave
untouched in org-version of course and support also in "make
info_git_describe".

Michael

Reply via email to