Patch 271 (http://patchwork.newartisans.com/patch/271/) is now "Accepted".
Maintainer comment: none This relates to the following submission: http://mid.gmane.org/%3C87zkvly3m3.fsf%40archdesk.localdomain%3E Here is the original message containing the patch: > Content-Type: text/plain; charset="utf-8" > MIME-Version: 1.0 > Content-Transfer-Encoding: 7bit > Subject: [Orgmode] Removed unecessary invocations of org-agenda-show. > Date: Mon, 13 Sep 2010 20:48:27 -0000 > From: Matt Lundin <m...@imapmail.org> > X-Patchwork-Id: 271 > Message-Id: <87zkvly3m3.fsf@archdesk.localdomain> > To: Org Mode <emacs-orgmode@gnu.org> > > lisp/org-agenda.el (org-agenda-set-tags): Remove org-agenda-show to prevent > disrupting windows and changing point in original buffer. > (org-agenda-set-property): Same > (org-agenda-set-effort): Same > (org-agenda-toggle-archive-tag): Same > > When setting a tag in the agenda, org-mode displays the corresponding > entry in the original org buffer by calling org-agenda-show. This has > the unwelcome side-effect of disrupting the current window arrangement > and changing the position of the point in the original buffer. This > behavior is inconsistent with the that of org-agenda-todo, which makes > all its changes "silently." > > Here is the offending line (6799) in org-agenda-set-tags: > > --8<---------------cut here---------------start------------->8--- > (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed > --8<---------------cut here---------------end--------------->8--- > > The same line occurs in org-agenda-set-property, org-agenda-set-effort, > and org-agenda-toggle-archive tag. > > --- > lisp/org-agenda.el | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 32c65db..784ba6a 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -6796,7 +6796,6 @@ the same tree node, and the headline of the tree node > in the Org-mode file." > (org-agenda-check-no-diary) > (if (and (org-region-active-p) (interactive-p)) > (call-interactively 'org-change-tag-in-region) > - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be > needed > (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker) > (org-agenda-error))) > (buffer (marker-buffer hdmarker)) > @@ -6825,7 +6824,6 @@ the same tree node, and the headline of the tree node > in the Org-mode file." > "Set a property for the current headline." > (interactive) > (org-agenda-check-no-diary) > - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be > needed > (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker) > (org-agenda-error))) > (buffer (marker-buffer hdmarker)) > @@ -6848,7 +6846,6 @@ the same tree node, and the headline of the tree node > in the Org-mode file." > "Set the effort property for the current headline." > (interactive) > (org-agenda-check-no-diary) > - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be > needed > (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker) > (org-agenda-error))) > (buffer (marker-buffer hdmarker)) > @@ -6872,7 +6869,6 @@ the same tree node, and the headline of the tree node > in the Org-mode file." > "Toggle the archive tag for the current entry." > (interactive) > (org-agenda-check-no-diary) > - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be > needed > (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker) > (org-agenda-error))) > (buffer (marker-buffer hdmarker)) >
