Bastien <b...@altern.org> writes: > Christian Egli <christian.e...@alumni.ethz.ch> writes: > >> +(defun org-taskjuggler-targeting-tj3-p () >> + "Return true if we are targeting TaskJuggler III." >> + (< org-export-taskjuggler-target-version 3.0)) > > I'm dubious on this one. > > Shouldn't it be > > #+begin_src emacs-lisp > (defun org-taskjuggler-targeting-tj3-p () > "Return true if we are targeting TaskJuggler III." > (> org-export-taskjuggler-target-version 3.0)) > #+end > > ?
Basically org-export-taskjuggler-target-version can be 2.4 or 3.0. So org-taskjuggler-targeting-tj3-p should return true if org-export-taskjuggler-target-version is 3.0 or higher and false otherwise. So, let's see what the *scratch* buffer has to say about this #+begin_src emacs-lisp (setq org-export-taskjuggler-target-version 2.4) 2.4 (defun org-taskjuggler-targeting-tj3-p () "Return true if we are targeting TaskJuggler III." (> org-export-taskjuggler-target-version 3.0)) org-taskjuggler-targeting-tj3-p (org-taskjuggler-targeting-tj3-p) nil (setq org-export-taskjuggler-target-version 3.0) 3.0 (org-taskjuggler-targeting-tj3-p) nil (setq org-export-taskjuggler-target-version 3.1) 3.1 (org-taskjuggler-targeting-tj3-p) t #+end Ah, you're right. There is a problem :-\. The correct version should be #+begin_src emacs-lisp (defun org-taskjuggler-targeting-tj3-p () "Return true if we are targeting TaskJuggler III." (>= org-export-taskjuggler-target-version 3.0)) #+end Let's test this in *scratch* #+begin_src emacs-lisp (setq org-export-taskjuggler-target-version 2.4) 2.4 (defun org-taskjuggler-targeting-tj3-p () "Return true if we are targeting TaskJuggler III." (>= org-export-taskjuggler-target-version 3.0)) org-taskjuggler-targeting-tj3-p (org-taskjuggler-targeting-tj3-p) nil (setq org-export-taskjuggler-target-version 3.0) 3.0 (org-taskjuggler-targeting-tj3-p) t (setq org-export-taskjuggler-target-version 3.1) 3.1 (org-taskjuggler-targeting-tj3-p) t #+end How do we proceed? Do I resubmit the patch? Thanks Christian -- Christian Egli Swiss Library for the Blind, Visually Impaired and Print Disabled Grubenstrasse 12, CH-8045 Zürich, Switzerland
