Hi Carsten, Thank you for the patch. This patch works for what it does, but does not handle the situations that I normally encounter the bug in.
To expand its scope, I made the the same change to the other of org-agenda-goto and org-agenda-switch-to and have used the combined patch (yours and mine) for quite a while now. I just have git rebase it every pull. It works for headlines but does not work for body text. Body text does not stay canonical. That is, you cannot achieve the state using motion and TAB in the buffer. Here is a test case. Search for applebanana and RET on it. Thanks. Samuel ***** example: my major headline test SCHEDULED: <2010-07-06 Tue> some body text. go up to the headline and fold the whole thing with tab, then search for apple.banana without the dot. you should notice that this entire body text is folded. does another variable control this? ******* my minor headline test applebanana SCHEDULED: <2010-07-06 Tue> ********* something underneath ********* again ******* another ********* under ********* under ******* more On 2010-05-14, Carsten Dominik <carsten.domi...@gmail.com> wrote: > > On May 7, 2010, at 7:32 AM, Samuel Wales wrote: > >> When I go to a location from the agenda, the next headline >> is revealed if it was hidden, even if it is a child. >> >> Setting org-show-following-heading to nil or leaving it at >> its default value does not prevent this. Should it? The >> documentation seems to suggest that it should. What I want >> is for hidden children to remain hidden. >> >> Rationale: I like the buffer to be in a form that can be >> obtained by navigation and cycling. For lack of a better >> term, I call that "canonical visibility". > > Hi Samuel, > > for some reason I do not remember, I enforce showing the next headline > in this special case. Please try the following patch and run with if > for a while, to see if it causes any problems. > > - Carsten > > > Modified lisp/org-agenda.el > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 19ea87c..d7bad10 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -6124,10 +6124,7 @@ and by additional input from the age of a > schedules or deadline entry." > (push-mark) > (goto-char pos) > (when (org-mode-p) > - (org-show-context 'agenda) > - (save-excursion > - (and (outline-next-heading) > - (org-flag-heading nil)))) ; show the next heading > + (org-show-context 'agenda)) > (recenter (/ (window-height) 2)) > (run-hooks 'org-agenda-after-show-hook) > (and highlight (org-highlight (point-at-bol) (point-at-eol))))) > > > >> >> Thanks. >> >> Samuel >> >> -- >> Q: How many CDC "scientists" does it take to change a lightbulb? >> A: "You only think it's dark." [CDC has denied a deadly disease for >> 25 years] >> ========== >> Retrovirus: http://www.wpinstitute.org/xmrv/index.html >> >> >> _______________________________________________ >> Emacs-orgmode mailing list >> Please use `Reply All' to send replies to the list. >> Emacs-orgmode@gnu.org >> http://lists.gnu.org/mailman/listinfo/emacs-orgmode > > - Carsten > > > > -- Q: How many CDC "scientists" does it take to change a lightbulb? A: "You only think it's dark." [CDC has denied a deadly disease for 25 years] ========== Retrovirus: http://www.wpinstitute.org/xmrv/index.html -- PLEASE DONATE _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode
