Hi again,

About the last patch in the message chain, I have found a simple change that makes it compile and work emacs-31 and master without the nasty messages when editing:

#+BEGIN_SRC diff
diff --git a/lisp/org-footnote.el b/lisp/org-footnote.el
index 43a48f670..79490e671 100644
--- a/lisp/org-footnote.el
+++ b/lisp/org-footnote.el
@@ -113,9 +113,8 @@ (defcustom org-footnote-section "Footnotes"
   `\\[universal-argument] \\[org-element-cache-reset]'"
   :group 'org-footnote
   :initialize 'custom-initialize-default
-  :set (lambda (var val &optional local)
-         (let ((custom-local-buffer nil))
-         (custom-set-default var val))
+  :set (lambda (var val &optional _)
+        (set-default-toplevel-value var val)
         (when (fboundp 'org-element-cache-reset)
           (org-element-cache-reset 'all)))
   :type '(choice
#+END_SRC

which, if you go back to the current master means that we only need to add an the optional anonymous parameter _ to the getter to silence emacs master and not interfere with emacs-31.

I don't have the time to test this in emacs-29 or emacs-30, but could help a volunteer running Org master on either emacs-29 or emacs-30 on what (s)he would have to do.

Best, /PA

On 22/10/26 23:01, Morgan Smith wrote:
Pedro Andres Aranda Gutierrez <[email protected]> writes:

As a side effect, I get rid of the setopt-local warning on Emacs 32, which I'm
test driving because it is currently starting to provide a nice internal
refactor engine which is quite convenient when hacking on ox-latex and
ox-beamer.

A refactor engine?  What exactly are you referring too?  I am quite
intrigued.


That said, there are additional motivations to start rethinking this:
1. simplification: one function less to take care of, and a very tricky one
because it dives into someone obscure details of Emacs Lisp: lexical bindings,
etc.
2. more in general: I already experience similar nasty messages when working on
the Org manual and ORG-NEWS. Am I the only one?

I would love to simplify the code-base and yes I am drowning in these
nasty messages.  I think I caught a glimpse of Ihor suffering as well at
the last meetup.

This is an important issue that we should solve.  I was just trying to
add some data to this report that might help resolve it.  Maybe I'll get
around to solving it myself but no promises :P

--
Pedro A. Aranda
ox-latex & ox-beamer maintainer

Sagen's Paradeiser! (ORF: Als Radiohören gefährlich war) => write BE!
IA: onomatopeya del rebuzno
2nd year of the New Koprocracy


Reply via email to