Morgan Smith <[email protected]> writes: > In my last thread, I tried to convince you that we shouldn't be loading > the loaddefs file and instead we should just use 'declare-function'. Ya > that's a pretty stupid take. Doing that makes it way too easy to rely > on functions that might not be loaded yet. > > Honestly I'm starting to think we should get rid of as many > 'declare-function' calls as possible. The attached patch successfully > removes 216 of them by loading the loaddefs file.
I have a problem with this idea - it will make it *even easier* to rely on functions that are autoloaded. You won't even have to add declare-function! Even though I see instances of requiring loaddefs in Emacs code, I do not think that it is a good practice from maintenance perspective. It will hide circular dependencies even more. I would really like to find some time to start merging my refactoring branch, where circular dependencies are less problematic. However, but with the current rate of incoming reports, it is a bit hard to find free time. Would you be willing to help me with making sure that we always reply to the reports and followups to the eisting reports within 1 month? The liaisons do help, but they do not cover all the reports, unfortunately. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
