Earl Chase <[email protected]> writes: > I wrote the patch that caused this, so this is my bad. We can't just change > the order of "(append valid-symbols (list 'contiguous-spaces > 'leading-and-trailing-spaces)))" as you suggested since > `org-link--remove-statistics-cookies' and 'org-link--remove-pipe-chars' can > add spaces to the search string. So instead we just trim twice, before we > attempt to normalize the search string and after we finish normalizing the > search string. I added new tests to confirm that this approach works.
Thanks! Several comments: 1. You copy-paste org-test-with-temp-text-in-file almost in full, removing (org-mode) call. Why not just doing something like (org-test-with-temp-text-in-file ... (fundamental-mode) ...)? 2. Please add Reported-by: and Link: to the report in the commit message. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
