Steve Holtz <[email protected]> writes: > I forgot to commit before creating the patch.... And, grief, I didn't > look at the patch before sending it. This is my first time sending > patched in this manner!
Happens, no problem. The patch system takes some getting used to, but has the advantage of keeping everything in the mailing list. > Please let me know if this looks better, or if you have suggestions! We're almost there. Three last things -- I could just fix them, but maybe you'd like to take a last pass? 1. The example in your last patch doesn't test right because: - There's still a hyphen in 'line-str' in the CALL line; it should be an underscore. - Python's ~range(10)~ actually yields 0-9, not 1-10, so the results shown are off by one from what the actual output would be. Either source or results need adjusting. 2. All the other LoB blocks are named with hyphens (kebab case) rather than underscore, so let's stick to that convention: the block NAME should be changed to 'extract-lines' and the CALL line changed accordingly. 3. Note the commit message conventions (we follow them for Worg as well to the extent it makes sense): https://orgmode.org/worg/org-contribute.html#commit-messages So your commit message should start with a line with the file changed and a short description of the overall change, e.g., minimally, library-of-babel.org: Add extract-lines It could optionally go on after a blank line with a more detailed changelog entry. I don't think that's needed here, but if you do, see the above link for formatting. Regards, Christian
