Morgan Smith <[email protected]> writes:

> +    ;; FIXME: Empty property equal to t?  Maybe not intentional?
> +    (should-not
> +     (org-test-with-temp-text "* TODO Blocked\n:PROPERTIES:\n:NOBLOCKING: 
> \n:END:\n** DONE one\n** TODO two"
> +       (org-entry-blocked-p)))

Even :NOBLOCKING: no will be treated as t. The code checks whether it is
present and not "nil". That's all.

> +    ;; FIXME: is this how commenting is supposed to work?
> +    (test-org-todo "* TODO COMMENT H" nil "* DONE COMMENT H")
> +    (test-org-todo "* COMMENT TODO H" nil "* DONE COMMENT H")

The second case looks like a bug.

> +                (let ((org-todo-keywords '((sequence "TODO" "DONE")
> +                                           (sequence "KWD1" "KWD2" "DONE"))))
> ...
> +    ;; Looping left and right has some quirks because "DONE" appears
> +    ;; in both sequences.  Is this the behavior we want?
> +    (test-org-todo "* H" 'right "* TODO H")
> +    (test-org-todo "* TODO H" 'right "* DONE H")
> +    (test-org-todo "* DONE H" 'right "* KWD1 H")
> +    (test-org-todo "* KWD1 H" 'right "* KWD2 H")
> +    (test-org-todo "* KWD2 H" 'right "* DONE H")
> +    (test-org-todo "* H" 'left "* DONE H")
> +    (test-org-todo "* DONE H" 'left "* TODO H")
> +    (test-org-todo "* TODO H" 'left "* H")
> +    (test-org-todo "* KWD2 H" 'left "* KWD1 H")
> +    (test-org-todo "* KWD1 H" 'left "* DONE H")

I think the way the code works is searching the keyword name via
'member', so the first instance "wins". But this is basically undefined
behavior. Do you really want to test for undefined behaviors?

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Reply via email to