Hi Christian, Thank you for taking the time to review these patches.
Christian Moe <[email protected]> writes: > Thanks for these! The dark theme is nice and legible (that's not > something I say often), and the accessibility enhancements are > welcome. Applied, thanks! > I think the move to rem left the ToC font size too relatively small to > read comfortably without zooming. That's the only thing I've spotted > that I'd like tweaked. I've used 1rem instead of 0.8, I hope it okay like that, feel free to adjust this value as you see fit. > The change from hover to focus reminds me: Do people actually have a way > to move focus to the ToC via keyboard in the first place? I realize I > actually don't know how to do it in Firefox: with the ToC collapsed by > default, TAB skips over it and takes me to the first link in the article > body. I've left that aside, along with the other a:focus-within proposal: this is clearly an area where more feedback from users is welcome. > Last time we discussed this, several people expressed a preference for > simply a static expanded ToC under the heading. Maybe time to revisit > that. https://list.orgmode.org/orgmode/[email protected]/ Part of the reason I started working on the new FAQ interface is because I find the TOC not really usable (as it is now or as a static TOC under the heading) - so I don't have any strong opinion here :) Best, -- Bastien
