Hi

Ping? Any more changes needed?

Comment inline

>> You still have an old
>> 
>>> ;; If the CJK font families have been included
>>>     ;; Check for polyglossia and/or babel and warn?
>>>     ;; Or advise for these packages to be added to 
>>> `org-latex-package-alist' ??
>>>     (when (and cjk-packages (equal compiler "xelatex"))
>>>       (message "Adding the CJK packages")
>>>       (goto-char (point-min))
>>>       (forward-line 2)
>>>       (insert "\\usepackage[CJKspace]{xeCJK}\n"))
>> 
>> in the code. Should it be removed?
> That’s what made things work for lualatex/xelatex with plain font spec.
> Remember that I was just talking about this working with *babel*…
> We should discuss whether the current way is enough or we also want a pure 
> fontspec/polyglossia solution too, given the added complexity shown in the 
> MWEs

I've added a small rewrite to move this to the beginning of the function and 
avoid (goto-char)…(forward-line)
I hope it reads better,,,

> 
>> Also, the new piece of code does not check for xelatex and will likely
>> make lualatex compilation fail. xeCJK only works with xelatex.
> 
> Right, I’ll add that

done

>> 
>>> @all: Please install or refresh the feature/all-tex-fonts to check the 
>>> results. A short section in the manual has been added, documenting my 
>>> current understanding of the state of the branch.
>> 
>> I think that the documentation should mention that things only work for
>> xelatex.
> OK, I’ll add that too..

Done

>> 
>> -- 
>> Ihor Radchenko // yantar92,
>> Org mode maintainer,
>> Learn more about Org mode at <https://orgmode.org/>.
>> Support Org development at <https://liberapay.com/org-mode>,
>> or support my work at <https://liberapay.com/yantar92>

Reply via email to