>>>>> On Fri, 24 Jan 2025 18:27:23 +0530, Visuwesh <visuwe...@gmail.com> said:
Visuwesh> [வெள்ளி ஜனவரி 24, 2025] Robert Pluim wrote:
>>>>>>> On Fri, 24 Jan 2025 10:37:37 +0530, Visuwesh <visuwe...@gmail.com>
said:
>>
Visuwesh> * lisp/org-compat.el: Add workaround proposed by Robert Pluim
Visuwesh> <rpl...@gmail.com> to make yank-media work under GNOME reliably
for
Visuwesh> Emacs 29.
>>
>> Did I propose it? I donʼt remember 😀
Visuwesh> You did, indeed. See https://yhetil.org/87wmlb8djy....@gmail.com.
I know, I was (feebly) attempting a joke.
>> I thought Ihor wanted this to check for a pgtk build? Personally I
>> think the check for the window system in the cl-defmethod is enough,
>> but Iʼm not Ihor.
Visuwesh> I think so too but let's hear from Ihor first.
>> One way to check for pgtk is checking the result of
>> (window-system). Or checking whether `pgtk-backend-display-class' is
>> `fboundp'.
And checking (window-system) duplicates the `cl-defmethod' check.
Visuwesh> I don't think we should use (window-system) since the return
value is
Visuwesh> FRAME dependent: if Someone™ opens a terminal frame first and
loads Org
Visuwesh> while it is focused, they won't get this fix even if their build
is a
Visuwesh> pgtk build. C:
Visuwesh> [ I think this will definitely break for daemon processes. ]
People who use the daemon are making a rod for their own back, but we
should still cater to them, I suppose.
Visuwesh> We could rely on (fboundp 'pgtk-backend-display-class) but I
somehow
Visuwesh> don't like it as compared to just leaving this extra check out.
Right.
Robert
--
