Derek Chen-Becker <de...@chen-becker.org> writes: >> The latest version of your patch exceeds 20LOC and cannot be accepted >> unless you have FSF copyright assignment. > > Sorry, that was clear in your previous comment. I am working on the > assignment form right now but I expect that to be a solved problem and I > want to continue to contribute to Org mode anyway, so I wanted to > parallelize that with continuing on the patch. If you would like me to stop > working on the patch until I have the copyright assignment taken care of, I > can do that, too.
Great. If you are going to have the copyright assignment, there is no limit on the patch size. It is just that we will need to wait until you finalize the assignment before we actually merge it. But nothing stops you and me from working on the patch before that. >> I recommend using `org-babel-effective-tangled-filename' instead. >> This is more future-proof against possible changes in the way file name >> is computed. >> > > I'm sorry, I don't quite understand. Do you mean I should change the > function name `org-base-buffer-file-name' to > `org-babel-effective-tangled-filename' or something else? Ouch. Never mind. I misread your patch. I thought that you are using :tangle yes in which case `org-babel-effective-tangle-filename' would be used to auto-generate the tangle file name. But that's not the case - you explicitly specify the tangle target. -- Ihor Radchenko // yantar92, Org mode maintainer, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
