Thanks for the help on this! I've reworked the changes into two patches (one for the README and one for tangle) and I think I've covered your concerns. I also added a unit test for the org-base-buffer-file-name function to cover the miss on provided buffers. Please let me know if you have any questions.
Thanks, Derek On Mon, Jan 13, 2025 at 10:21 AM Ihor Radchenko <yanta...@posteo.net> wrote: > Derek Chen-Becker <de...@chen-becker.org> writes: > > >> Also, what about other places in the code that use `buffer-file-name'? > >> We may want to use the new function there as well. > > > > Definitely. There are hundreds of places in the code where the same > pattern > > applies. Per our previous discussion in the thread, though, I thought it > > would be better to start small and incrementally work through them. If > you > > want me to include more changes,I'm going to need to help sorting all of > > these out: > > > > ❯ rg -q --stats buffer-file-name > > 185 matches > > 182 matched lines > > It is ok to only limit the current patch to fixing the bug in question. > We can continue with more changes later, after merging the more limited > patch. > > -- > Ihor Radchenko // yantar92, > Org mode maintainer, > Learn more about Org mode at <https://orgmode.org/>. > Support Org development at <https://liberapay.com/org-mode>, > or support my work at <https://liberapay.com/yantar92> > -- +---------------------------------------------------------------+ | Derek Chen-Becker | | GPG Key available at https://keybase.io/dchenbecker and | | https://pgp.mit.edu/pks/lookup?search=derek%40chen-becker.org | | Fngrprnt: EB8A 6480 F0A3 C8EB C1E7 7F42 AFC5 AFEE 96E4 6ACC | +---------------------------------------------------------------+
0002-ob-tangle-Ensure-proper-tangling-within-a-capture-bu.patch
Description: Binary data
0001-testing-README-Add-details-on-use-of-TEST_NO_AUTOCLE.patch
Description: Binary data
