Karthik Chikmagalur <karthikchikmaga...@gmail.com> writes: > I have one more question for you: > > The overlay property that is used to check if it corresponds to a link > preview is inconsistent with the rest of Org right now. We are checking > for the non-nil overlay property `org-image-overlay'. > > 1. Should we rename this property to `org-link-preview-overlay', or > `org-link-preview'? > > 2. Org's LaTeX previews (both the existing and WIP versions) use a > different system. They set two overlay properties: `category' set to > `org', and `org-overlay-type', set to `org-latex-preview'. Should we > use a consistent set of properties to identify Org-related overlays?
May you elaborate on why you went with category = 'org? category property has a special meaning in overlays. > This is an implementation detail and none of it really matters, but I > can unify them if required. What I am certain about is that we do need to keep `org-image-overlay' property as it might be used by third-party code. We may add something extra to make things more consistent across Org mode, but `org-image-overlay' must be kept for backwards compatibility reasons. > +Org mode can display previews of [[*Hyperlinks][hyperlinks]] inside Org > buffers. By I just started doing a final pass of the proofreading and figured that we should not use links to other parts of the manual or other manuals that have description. This is because texinfo formats them unexpectedly, as Section X.X [description], page YYY. May you please run make docs with your patch and look into the results org.pdf file? We need to make sure that things the new section is readable there. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
