Hi Ihor, thank you for your review.
Ihor Radchenko <yanta...@posteo.net> writes: > According to our records in https://orgmode.org/worg/contributors.html, > you haven't signed FSF copyright agreement. May you add a TINYCHANGE > cookie to the commit message as required by > https://orgmode.org/worg/org-contribute.html#first-patch I've signed the FSF copyright agreement in the context of my contributions to Emacs. Do I need to do any more paperwork? I've added TINYCHANGE to the patch anyway. >> + (error (if noerror >> + (message "%s %S" (car error) (cdr error)) >> + (signal (car error) (cdr error))))) > > I think that it will be a good idea to indicate in the `message' where > the error is coming from. The error intercepted by this `condition-case' > form will likely be a network error, and it may be unclear to the user > which function is failing to make the connection. I tried to make that a little bit clearer: (message "Org could't download \"%s\": %s %S" file (car error) (cdr error)) Do you want me to explicitly refer to the current function name? -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill
