Samuel Wales <samolog...@gmail.com> writes: > maybe my comment is too unrelated to the patch, but it just seemed > worth raising in the context. to me it feels wrong to have a > non-linline-task child entry whose heading is star-indented more > levels than needed to denote a child entry. > > in my own case, it suggests corruption, because i would not > deliberately create that. i have encountered it. similarly if > org-odd-levels-only is non-nil and there is an even star heading. i > have encountered it. confusing to track down. > > i was merely asking if there was anything in e.g. main or syntax > documents etc. that refers to or enforces this.
I have seen some checks in the code to ensure not breaking structure. They may not be ideal, indeed. Hard to say much without a reproducer. > as for active region or transient mark, to me, they are supposed to be > transient, unlike, for example, agenda restriction lock, and thus, for > example, having to c-g or so to get rid of a highlighted region feels > like a bug. > > there might be exceptions where you pretty much always want to run a > command more than once with the region remaining active, perhaps such > as a rectange opening type of command, but to me the patch commands do > not apply there. The patch is mostly aiming at M-arrow commands. I feel like M-arrow are issued repeatedly quite often. We may also provide a defcustom. Though I will be in favour of keeping "do not deactivate selection" as the default of such defcustom. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at <https://orgmode.org/>. Support Org development at <https://liberapay.com/org-mode>, or support my work at <https://liberapay.com/yantar92>
