Hi Ihor, I somehow seem to remember that the async tests were also broken with python.el (python-mode.el not installed). at least sometimes? or is this only the underscore test? If it's only the underscore test, I would suggest not installing python-mode for ci and ignoring the really flaky tests (i think the underscore one is a candidate here).
I somehow got the async things mixed up with the flaky tests, which is not true for python-mode.el installed. what do you think? I really would like to see python tests pass ... Kind regards, Christian On Thu, Nov 3, 2022 at 8:13 AM Ihor Radchenko <yanta...@posteo.net> wrote: > > Christian Köstlin <christian.koest...@gmail.com> writes: > > > With my patch the tests are still failing but the testsuite continues > > to run and returns > > with 0 as status code (one can see the failed test though). > > FYI, I am using automated scripts to run make test locally on multiple > Emacs versions. 0 status code would do no good for my testing. > > >> Maybe we can instead provide some variable that can turn-on ignoring > >> some problematic tests only during CI tests? > > Yes ... that would also be possible e.g. skip the test or test nothing > > if it's running on the ci. > > (I am talking only about the 3 tests!). > > More like just 1 test with underscore :) > The 3 tests in the patch are real failures because ob-python does not > fully support python-mode.el. > > -- > Ihor Radchenko // yantar92, > Org mode contributor, > Learn more about Org mode at <https://orgmode.org/>. > Support Org development at <https://liberapay.com/org-mode>, > or support my work at <https://liberapay.com/yantar92>
