Hello, Kaushal Modi <kaushal.m...@gmail.com> writes:
> Can this commit[1] be merged into the main branch. It is already in the main branch, AFAIU. I assume you mean it should be back-ported to bugfix branch. If that's the case, I don't know. This is a new feature, and not a critical one: there are workarounds, as you found out. This should be available when Org 9.6 is released. I don't know when that will happen. > I believe the behavior I see with this commit on main branch is kind > of obvious and it should prevent this surprise failure for other users > too. It's obvious, but, as a new feature, it was pushed to main instead of bugfix. Note that the error message is explicit anyway. I'm not strictly opposed to back-porting it to bugfix, but is there a compelling reason to break our workflow in this case? > This works for both main and bugfix, but while doing this, I realized > that even string values are not considered safe for this variable. > > Looking through git revisions, I found > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=41e67cff0d3bf27ffb57f9a230598b0385341517. n> > Earlier `:safe t' was added for `org-cite-csl-styles-dir'. Instead can > we have `:safe #'string-or-null-p' as suggested by Glenn Morris in > that commit? I don't think Glenn Morris suggests using #'string-or-null-p, which would contradict his statement. He is pointing out that ":safe #'string-or-null-p" is better than ":safe t", even though but allowing arbitrary locations (strings in this case) is not safe anyway. Regards, -- Nicolas Goaziou
