Hello!
I'm trying to make multi-frame emacsing nicer, and I encountered what I
consider a bug with the `org-no-popups` macro in `org-macs.el`.
`org-no-popups` tries to surpress the creation of new frames via setting
`pop-up-frames` and `display-buffer-alist` to nil temporarily. This does
not take `display-buffer-fallback-action` into account, which is the
preferred way of making Emacs pop up new frames (or not, as the case may
be). When the fallback variable is set, code run inside `org-no-popups`
still creates new popups, which causes functions such as
`org-insert-link` to fail, or at least act *very* confusingly.
The preferred way of overriding the behavior of `display-buffer` for
localized Emacs code seems to be the variable
`display-buffer-overriding-action`.
Changing the definition of `org-no-popups` to
```
(defmacro org-no-popups (&rest body)
"Suppress popup windows and evaluate BODY."
`(let ((display-buffer-overriding-action '(display-buffer-pop-up-window)))
,@body))
```
correctly makes org pop up windows instead of frames.
Please contact me if you have any questions!
Best regards,
Jan Seeger
---
Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.30,
cairo version 1.16.0)
Package: Org mode version 9.4.6 (9.4.6-13-g4be129-elpaplus @
/home/jeeger/.emacs.d/elpa/org-plus-contrib-20210920/)
