Max Nikulin <maniku...@gmail.com> writes: > It seems, each case of `org-no-popups' may require specific code. I have > tried to take some code related to completion. It overrides > display-buffer-base-action, but something more is required for > pop-up-frames.
I think you went too far. display-buffer-base-action is mostly for user to specify. We should not override it. If user needs adjustments for *Org Help*, it is always possible using a custom function inside display-buffer-base-action. I do not think that we need to do this job for the user. >From my perspective, there is no need to prevent users from shooting their own leg (we are in Emacs after all). The cases we may need to interfere are: (1) when some user customisations are mostly ok, except they affect Org's usability, and the user has no easy way to fix it; (2) when some customisation is very common and we significantly help many users by supporting such customisation in Org itself. I think pop-up-windows customisation qualifies for "(1)". Not display-buffer-base-action. Best, Ihor
