On 05/10/2021 19:45, Ihor Radchenko wrote:
Max Nikulin writes:
Regression is caused by
commit 399481bad10845a77f210c9320ff1efee9a312c8
Author: Ihor Radchenko <yanta...@gmail.com>
Date: Mon May 31 20:47:45 2021 +0800
Do not ignore user-defined display-buffer-alist in org-insert-link
See the attached fix. The fix looks reasonable, though I fail to
understand why org-no-popup was even used in org-goto-location. We kind
of want a popup there. git blame did not reveal anything useful either.
Thank you, Ihor. I am a user of alternative `org-goto' interface. I have
tried default one having a couple of windows in the frame (indirect
buffer for subtree, indirect for src block). It seems, previous window
configuration is restored correctly when `org-goto' is finished.
Curiously `org-no-popup' was introduced namely for `org-goto`
commit b508943d329fed2af457c50afd5f63938b23c58c
Author: Achim Gratz <strom...@stromeko.de>
Date: Thu Dec 20 10:18:02 2012 +0100
org-compat: new macro org-no-popups
* lisp/org-compat.el (org-no-popups): New wrapper macro which
let-binds the correct variables to suppress popup windows depending
on the Emacs version in use. This is a compile-time decision when
byte-compiling.
* lisp/org.el (org-get-location, org-switch-to-buffer-other-window):
Use the wrapper `org-no-popups´ to let-bind the correct variables
for suppression of popup window
To emphasize actual changes due to the patch just suggested by Ihor:
git diff -b HEAD~
diff --git a/lisp/org-goto.el b/lisp/org-goto.el
index 0a3470f54..352bf9f2e 100644
--- a/lisp/org-goto.el
+++ b/lisp/org-goto.el
@@ -203,7 +203,6 @@ When nil, you can use these keybindings to navigate
the buffer:
"Let the user select a location in current buffer.
This function uses a recursive edit. It returns the selected
position or nil."
- (org-no-popups
(let ((isearch-mode-map org-goto-local-auto-isearch-map)
(isearch-hide-immediately nil)
(isearch-search-fun-function
@@ -236,7 +235,7 @@ position or nil."
(use-local-map org-goto-map)
(recursive-edit)))
(kill-buffer "*org-goto*")
- (cons org-goto-selected-point org-goto-exit-command))))
+ (cons org-goto-selected-point org-goto-exit-command)))
;;;###autoload
(defun org-goto (&optional alternative-interface)
