Hi Bastien,
Bastien writes:
I tried to apply this (transitory?) patch against maint and it did not
apply. It applies okay on master. For bug fixes, please make patches
againt the maint branch.
This fixes a bug introduced by a commit in master. I've attached the same
patch here, properly formated. I think it should be applied to master.
It reverts a part of a2cb9b853: permissions are no longer set before writing
to the tangled file.
I've CC'd Tom, which made the original suggestion. I guess we could set the
write and execute permissions before writing, and set the read permissions
afterwards.
--
Sébastien Miquel
>From e56a05f4f5a3cce9cfdeb71854475e29aac1a6e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Miquel?= <sebastien.miq...@posteo.eu>
Date: Tue, 4 May 2021 22:59:36 +0200
Subject: [PATCH] ob-tangle.el (org-babel-tangle): Fix readonly tangle
* lisp/ob-tangle.el (org-babel-tangle): Fix readonly tangle.
---
lisp/ob-tangle.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el
index 36144d6ae..96a4ef049 100644
--- a/lisp/ob-tangle.el
+++ b/lisp/ob-tangle.el
@@ -268,11 +268,11 @@ matching a regular expression."
lspecs)
(when make-dir
(make-directory fnd 'parents))
- ;; erase previous file and set permissions on empty
- ;; file before writing
- (write-region "" nil file-name nil 0)
- (mapc (lambda (mode) (set-file-modes file-name mode)) modes)
+ ;; erase previous file
+ (when (file-exists-p file-name)
+ (delete-file file-name))
(write-region nil nil file-name)
+ (mapc (lambda (mode) (set-file-modes file-name mode)) modes)
(push file-name path-collector))))))
(if (equal arg '(4))
(org-babel-tangle-single-block 1 t)
--
2.31.1
