Hello,
The following tests fail as of ae9cd4370 (org-attach*, org, org-manual,
org-news, ox-html, testing/*, 2018-11-25):
test-org-attach-git/get-maybe
test-org-attach-git/use-annex
test-org-attach/dired-attach-to-next-best-subtree/1
test-org-attach/dired-attach-to-next-best-subtree/2
Gustav, could you please take a look? I suspect you didn't see these
failures when you made those changes because you don't have git-annex
installed.
Here are the backtraces:
--8<---------------cut here---------------start------------->8---
selected tests: org-attach
Running 5 tests (2019-09-02 18:22:55-0400)
(Shell command succeeded with no output)
(Shell command succeeded with no output)
Test test-org-attach-git/get-maybe backtrace:
(org-attach-annex-get-maybe (expand-file-name "test-file"))
(let ((org-attach-annex-auto-get t)) (org-attach-annex-get-maybe (ex
(let ((path (expand-file-name "test-file")) (annex-dup (make-temp-fi
(let ((default-directory tmpdir) (org-attach-id-dir tmpdir)) (shell-
(unwind-protect (let ((default-directory tmpdir) (org-attach-id-dir
(let ((tmpdir (make-temp-file "org-annex-test" t "/"))) (unwind-prot
(lambda nil (let ((tmpdir (make-temp-file "org-annex-test" t "/")))
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name test-org-attach-git/get-maybe :docume
ert-run-or-rerun-test(#s(ert--stats :selector "org-attach" :tests [#
ert-run-tests("org-attach" #f(compiled-function (event-type &rest ev
ert-run-tests-batch("org-attach")
ert-run-tests-batch-and-exit("org-attach")
(let ((org-id-track-globally t) (org-test-selector (if org-test-sele
org-test-run-batch-tests("org-attach")
eval((org-test-run-batch-tests org-test-select-re))
command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
command-line()
normal-top-level()
Test test-org-attach-git/get-maybe condition:
(void-function org-attach-annex-get-maybe)
FAILED 1/5 test-org-attach-git/get-maybe
Test test-org-attach-git/use-annex backtrace:
org-attach-use-annex()
apply(org-attach-use-annex nil)
(setq value-3425 (apply fn-3423 args-3424))
(unwind-protect (setq value-3425 (apply fn-3423 args-3424)) (setq fo
(if (unwind-protect (setq value-3425 (apply fn-3423 args-3424)) (set
(let (form-description-3427) (if (unwind-protect (setq value-3425 (a
(let ((value-3425 (quote ert-form-evaluation-aborted-3426))) (let (f
(let* ((fn-3423 (function org-attach-use-annex)) (args-3424 (conditi
(let ((org-attach-git-annex-cutoff 1)) (let* ((fn-3423 (function org
(let ((default-directory tmpdir) (org-attach-id-dir tmpdir)) (shell-
(unwind-protect (let ((default-directory tmpdir) (org-attach-id-dir
(let ((tmpdir (make-temp-file "org-annex-test" t "/"))) (unwind-prot
(lambda nil (let ((tmpdir (make-temp-file "org-annex-test" t "/")))
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name test-org-attach-git/use-annex :docume
ert-run-or-rerun-test(#s(ert--stats :selector "org-attach" :tests [#
ert-run-tests("org-attach" #f(compiled-function (event-type &rest ev
ert-run-tests-batch("org-attach")
ert-run-tests-batch-and-exit("org-attach")
(let ((org-id-track-globally t) (org-test-selector (if org-test-sele
org-test-run-batch-tests("org-attach")
eval((org-test-run-batch-tests org-test-select-re))
command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
command-line()
normal-top-level()
Test test-org-attach-git/use-annex condition:
(void-function org-attach-use-annex)
FAILED 2/5 test-org-attach-git/use-annex
passed 3/5 test-org-attach/dir
Test test-org-attach/dired-attach-to-next-best-subtree/1 backtrace:
org-attach-git-commit("/tmp/tmp-orgtest/data/73/65ffd7-1e1f-40e3-a9a
run-hook-with-args(org-attach-git-commit "/tmp/tmp-orgtest/data/73/6
(let* ((attach-dir (org-attach-dir (quote get-create))) (fname (expa
(let ((basename (file-name-nondirectory file))) (let* ((attach-dir (
org-attach-attach("/tmp/tmp-orgtest/acrffdU")
(let ((file (car --dolist-tail--))) (org-attach-attach file) (setq -
(while --dolist-tail-- (let ((file (car --dolist-tail--))) (org-atta
(let ((--dolist-tail-- files)) (while --dolist-tail-- (let ((file (c
(let ((start-win (selected-window)) (other-win (get-window-with-pred
org-attach-dired-to-subtree(("/tmp/tmp-orgtest/acrffdU"))
funcall-interactively(org-attach-dired-to-subtree ("/tmp/tmp-orgtest
call-interactively(org-attach-dired-to-subtree)
(progn (split-window) (dired temporary-file-directory) (progn (or (e
(progn (setq buffer (find-file file)) (if (re-search-forward "<point
(unwind-protect (progn (setq buffer (find-file file)) (if (re-search
(let ((file (make-temp-file "org-test")) (inside-text (if (stringp "
(unwind-protect (let ((file (make-temp-file "org-test")) (inside-tex
(let ((a-filename (make-temp-file "a"))) (unwind-protect (let ((file
(setq value-3527 (let ((a-filename (make-temp-file "a"))) (unwind-pr
(unwind-protect (setq value-3527 (let ((a-filename (make-temp-file "
(if (unwind-protect (setq value-3527 (let ((a-filename (make-temp-fi
(let (form-description-3528) (if (unwind-protect (setq value-3527 (l
(let ((value-3527 (gensym "ert-form-evaluation-aborted-"))) (let (fo
(closure (t) nil (let ((value-3527 (gensym "ert-form-evaluation-abor
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name test-org-attach/dired-attach-to-next-
ert-run-or-rerun-test(#s(ert--stats :selector "org-attach" :tests [#
ert-run-tests("org-attach" #f(compiled-function (event-type &rest ev
ert-run-tests-batch("org-attach")
ert-run-tests-batch-and-exit("org-attach")
(let ((org-id-track-globally t) (org-test-selector (if org-test-sele
org-test-run-batch-tests("org-attach")
eval((org-test-run-batch-tests org-test-select-re))
command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
command-line()
normal-top-level()
Test test-org-attach/dired-attach-to-next-best-subtree/1 condition:
(wrong-number-of-arguments
((t)
nil "Commit changes to git if `org-attach-id-dir' is properly initialized.
This checks for the existence of a \".git\" directory in that directory."
(let*
((dir ...)
(git-dir ...)
(use-annex ...)
(changes 0))
(if
(and git-dir ...)
(progn ...))))
1)
FAILED 4/5 test-org-attach/dired-attach-to-next-best-subtree/1
Directory has changed on disk; type g to update Dired
Test test-org-attach/dired-attach-to-next-best-subtree/2 backtrace:
org-attach-git-commit("/tmp/tmp-orgtest/data/cb/6acd9b-4618-478e-907
run-hook-with-args(org-attach-git-commit "/tmp/tmp-orgtest/data/cb/6
(let* ((attach-dir (org-attach-dir (quote get-create))) (fname (expa
(let ((basename (file-name-nondirectory file))) (let* ((attach-dir (
org-attach-attach("/tmp/tmp-orgtest/a69HoUW")
(let ((file (car --dolist-tail--))) (org-attach-attach file) (setq -
(while --dolist-tail-- (let ((file (car --dolist-tail--))) (org-atta
(let ((--dolist-tail-- files)) (while --dolist-tail-- (let ((file (c
(let ((start-win (selected-window)) (other-win (get-window-with-pred
org-attach-dired-to-subtree(("/tmp/tmp-orgtest/a69HoUW" "/tmp/tmp-or
funcall-interactively(org-attach-dired-to-subtree ("/tmp/tmp-orgtest
call-interactively(org-attach-dired-to-subtree)
(progn (split-window) (dired temporary-file-directory) (progn (or (e
(progn (setq buffer (find-file file)) (if (re-search-forward "<point
(unwind-protect (progn (setq buffer (find-file file)) (if (re-search
(let ((file (make-temp-file "org-test")) (inside-text (if (stringp "
(unwind-protect (let ((file (make-temp-file "org-test")) (inside-tex
(let ((a-filename (make-temp-file "a")) (b-filename (make-temp-file
(setq value-3529 (let ((a-filename (make-temp-file "a")) (b-filename
(unwind-protect (setq value-3529 (let ((a-filename (make-temp-file "
(if (unwind-protect (setq value-3529 (let ((a-filename (make-temp-fi
(let (form-description-3530) (if (unwind-protect (setq value-3529 (l
(let ((value-3529 (gensym "ert-form-evaluation-aborted-"))) (let (fo
(closure (t) nil (let ((value-3529 (gensym "ert-form-evaluation-abor
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name test-org-attach/dired-attach-to-next-
ert-run-or-rerun-test(#s(ert--stats :selector "org-attach" :tests [#
ert-run-tests("org-attach" #f(compiled-function (event-type &rest ev
ert-run-tests-batch("org-attach")
ert-run-tests-batch-and-exit("org-attach")
(let ((org-id-track-globally t) (org-test-selector (if org-test-sele
org-test-run-batch-tests("org-attach")
eval((org-test-run-batch-tests org-test-select-re))
command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
command-line()
normal-top-level()
Test test-org-attach/dired-attach-to-next-best-subtree/2 condition:
(wrong-number-of-arguments
((t)
nil "Commit changes to git if `org-attach-id-dir' is properly initialized.
This checks for the existence of a \".git\" directory in that directory."
(let*
((dir ...)
(git-dir ...)
(use-annex ...)
(changes 0))
(if
(and git-dir ...)
(progn ...))))
1)
FAILED 5/5 test-org-attach/dired-attach-to-next-best-subtree/2
Ran 5 tests, 1 results as expected, 4 unexpected (2019-09-02 18:22:57-0400)
4 unexpected results:
FAILED test-org-attach-git/get-maybe
FAILED test-org-attach-git/use-annex
FAILED test-org-attach/dired-attach-to-next-best-subtree/1
FAILED test-org-attach/dired-attach-to-next-best-subtree/2
mk/targets.mk:104: recipe for target 'test-dirty' failed
make: *** [test-dirty] Error 1
--8<---------------cut here---------------end--------------->8---
