Re: [O] [PATCH 2/2] org-capture.el: Support all target file specifiction variants in Customize

[Nicolas Goaziou]

Hello,

Phil Hudson <phil.hud...@iname.com> writes:

> From 9ca987e6580ef633c961bf2023813d8544a0d36b Mon Sep 17 00:00:00 2001
> From: Phil Hudson <phil.hud...@iname.com>
> Date: Wed, 11 May 2016 22:49:01 +0100
> Subject: [PATCH 2/2] org-capture.el: Support all target file specifiction
>  variants in Customize

I cannot apply this patch. Could you rebase against maint and try
sending it again? Thank you.


>                               (const :format "" file)
> -                             (file :tag "  File"))
> +                             (choice :tag "  Filename"
> +                                     (file :tag "  Literal")
> +                                     (function :tag "  Function")
> +                                     (variable :tag "  Variable")
> +                                     (sexp :tag "  Form")))

I think you can remove all most of the redundancy using backquote, e.g.,

  (let ((file-sources '(choice :tag "  Filename"
                               (file :tag "  Literal")
                               (function :tag "  Function")
                               (variable :tag "  Variable")
                               (sexp :tag "  Form"))))
    `(repeat
      ...
      (choice :tag "Target location"
              (const :format "" file)
              ,file-sources)
      ...))


Regards,

-- 
Nicolas Goaziou