Hello, Michael Brand <michael.ch.br...@gmail.com> writes:
> Hi Julien > > On Fri, Feb 5, 2016 at 6:46 AM, Julien Cubizolles <j.cubizol...@free.fr> > wrote: >> I've been using org-pdfview (from >> https://github.com/markus1189/org-pdfview) to have org-mode open pdf >> files generated during export. >> >> --8<---------------cut here---------------start------------->8--- >> (pdf-tools-install) >> (eval-after-load 'org '(progn (require 'org-pdfview) >> (add-to-list 'org-file-apps '("\\.pdf\\'" . >> org-pdfview-open)) >> )) >> --8<---------------cut here---------------end--------------->8--- >> >> Since a recent upgrade, this fails with: >> >> --8<---------------cut here---------------start------------->8--- >> (wrong-number-of-arguments #[(link) "\304\305 \"\2031\306\307 \"\310\306\311 >> \"!\310\306\312 \"!\313 \307\"\210\314 >> !\210\315\316 \317 @_\320 \245!!+\207\304\321 \"\203N\306\307 \"\310\306\311 >> \"!\313 \307\"\210\314 >> !*\207\313 \307\"\207" [link path page height string-match >> "\\(.*\\)::\\([0-9]*\\)\\+\\+\\([[0-9]\\.*[0-9]*\\)" match-string 1 >> string-to-number 2 3 org-open-file pdf-view-goto-page >> image-set-window-vscroll round pdf-view-image-size frame-char-height >> "\\(.*\\)::\\([0-9]+\\)$"] 4 >> ("/home/wilk/.emacs.d/elpa/org-pdfview-20160125.1254/org-pdfview.elc" . >> 662)] 2) >> >> org-pdfview-open("/home/wilk/enseignement/2015-2016/topos/topo-tipe-beamer.pdf" >> "/home/wilk/enseignement/2015-2016/topos/topo-tipe-beamer.pdf") >> --8<---------------cut here---------------end--------------->8--- >> >> Is it a bug in Org-mode or should I report the issue to the org-pdfview >> author ? > > Due to lexical binding in org.el there was a change in > `org-file-apps', see Org News for version 9.0 and e. g. this thread: > http://thread.gmane.org/gmane.emacs.orgmode/104272 > I think the most convenient would be if `org-open-file' tries to find > out that `cmd' in this case is a function with only one argument and > call it with just `file'. > > @Nicolas: Is this reasonable for you to implement? I think the simplest solution may be to follow the advice in ORG-NEWS and use (lambda (file link) (org-pdfview-open file)) Regards, -- Nicolas Goaziou
