yes, I now found the "how to contribute" page :) the updated patch is
attached. thanks!
Nicolas Goaziou <m...@nicolasgoaziou.fr> writes:
> Hello,
>
> Thomas Alexander Gerds <t...@biostat.ku.dk> writes:
>
>> great. the updated patch is attached.
>
> It looks good. Thank you. One minor comment below.
>
>> for ORG-NEWS:
>> ,----
>> | *** Links **** Links stored by org-gnus-store-link in nnir groups
>> |
>> | Since gnus nnir groups are temporary, org-gnus-store-link now
>> | refers to the article's original group.
>> `----
>
> OK.
>
>> commit f56d29a57ed965029c1b5f3929f3085423e46f18 Author: Thomas
>> Alexander Gerds <t...@biostat.ku.dk> Date: Thu Dec 17 06:57:11 2015
>> +0100
>> org-gnus: avoid links to nnir groups
>
> "Avoid"
>
> You also need to refer to the function modified, e.g.,
>
> * lisp/org-gnus.el (org-gnus-store-link): Articles in an nnir group
> refer to the original group.
>
> Eventually, if you haven't signed FSF papers, you also need to add
> "TINYCHANGE" at the end of the message.
>
> Regards,
--
Thomas A. Gerds -- Assoc. Prof. Department of Biostatistics
University of Copenhagen, Oester Farimagsgade 5, 1014 Copenhagen, Denmark
Office: CSS-15.2.07 (Gamle Kommunehospital)
tel: 35327914 (sec: 35327901)
>From 907bf2c9b474a740f6ec4cbe8a79db1b7d995276 Mon Sep 17 00:00:00 2001
From: Thomas Alexander Gerds <t...@biostat.ku.dk>
Date: Fri, 18 Dec 2015 07:43:38 +0100
Subject: [PATCH] org-gnus.el: change nnir group reference
* lisp/org-gnus.el (org-gnus-store-link): Articles in an nnir group refer to the original group
TINYCHANGE
---
lisp/org-gnus.el | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index c7b46af..11345a0 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -172,10 +172,12 @@ If `org-store-link' was called with a prefix arg the meaning of
(subject (copy-sequence (mail-header-subject header)))
(to (cdr (assq 'To (mail-header-extra header))))
newsgroups x-no-archive desc link)
- (when (eq (car (gnus-find-method-for-group gnus-newsgroup-name))
- 'nnvirtual)
- (setq group (car (nnvirtual-map-article
- (gnus-summary-article-number)))))
+ (cl-case (car (gnus-find-method-for-group gnus-newsgroup-name))
+ (nnvirtual
+ (setq group (car (nnvirtual-map-article
+ (gnus-summary-article-number)))))
+ (nnir
+ (setq group (nnir-article-group (gnus-summary-article-number)))))
;; Remove text properties of subject string to avoid Emacs bug
;; #3506
(set-text-properties 0 (length subject) nil subject)
--
2.1.4
