Hi Chuck,
The patch is fundamentally correct, please push it. A couple minor
comments:
2015ko azaroak 7an, "Charles C. Berry"-ek idatzi zuen:
[...]
> + (`query (or
> + (and (not (org-bound-and-true-p
> + org-babel-confirm-evaluate-answer-no))
> + (yes-or-no-p
> + (format "Evaluate this %s code block%s on your system? "
^^^
Rather than inserting that space, you should make the no-name value of
name-string a single space. Otherwise there will be two spaces if the
block does have a name.
> + lang name-string)))
> + (and
> + (message "Evaluation of this %s code-block%s is aborted."
> + lang name-string)
> + nil)))
I think ‘progn’ would be better than ‘and’ here, just as a matter of
style. Same comment as above applies about the extra space.
Thanks very much for the patch, and sorry for the breakage,
Aaron
PS Git gave me some strange errors about trailing whitespace when trying
to apply your patch, until I converted it from DOS to Unix line
endings. I’ve never seen git do that before – I think it usually copes
very well with different line ending styles. Does anyone know what to
do in this scenario? Manually changing the line endings of the patch
file seems hackish.
--
Aaron Ecay
