> > About 4, what if we call it --fail-if-any? Or alternatively, --at-most=0 (and you can set it to any positive integer)? > `at-most` is short and sweet 👍
I think it's important for this flag name to communicate that it will cause a failure. at-most sounds like it would simply limit graph depth, rather than return a non-zero status code if the graph is over a certain depth. Maybe --failure-depth=2 or --fail-at=3? On Wednesday, June 2, 2021 at 10:47:23 AM UTC-7 Marc-André Lafortune wrote: > On Wed, Jun 2, 2021 at 1:31 PM José Valim <[email protected]> wrote: > >> Would `--label transient-compile` filter out all dependencies that are >>> either not compile time, or those that are compile-time but towards a sink >>> with no dependency? >>> E.g.: A => B (runtime) => C (compile) => D (anything): clearly `B => C` >>> needs to be selected, but would `A => B` also be selected (unless >>> `--only-direct` is specified)? >>> >> >> For the graph above, I believe today label=compile will show A => B => C. >> But it will only include D if it is compile time (or if something after D >> is compile time). So it includes direct dependencies and transitive >> dependencies. In this case, it is transitive because we are including a >> runtime dependency since there is a compile time node after. So yes, I >> agree my suggestion was bad/confusing. :) >> >> In your case, you only want to show the graph at all if there is a >> dependency after a compile-time node, so it is more like >> "compile-connected"? Does that make sense? >> > > ` --label "compile-connected"` makes sense 👍 > > About 2, let's go with --only-sinks option (and I will rename later on >> --only-nodes to --only-sources). >> > > 👍 > > >> About 4, what if we call it --fail-if-any? Or alternatively, --at-most=0 >> (and you can set it to any positive integer)? >> > > `at-most` is short and sweet 👍 > > I'll prepare some PRs > -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/7769592b-3869-44ce-b9f2-8685e9e26e56n%40googlegroups.com.
