If we are adding this conversion only from within from_iso8601 then we probably don't need a new callback because we always need to create a complete isoday reference first.
On Thu, Feb 4, 2021 at 11:24 PM Kip Cole <[email protected]> wrote: > > Ordinal dates are interesting because while they are not calendar > dates, they are trivially convertible into them. > > True for the proleptic Gregorian calendar, not necessarily so for other > calendars. Since ISO8601 is explicitly only concerned with that calendar I > expect this isn’t an issue. > > However given ordinal days of the year do exist for all calendars (that > I’m aware of since they all have the concept of a day) perhaps adding a > callback to `Calendar` of something like `month_and_day_from_ordinal(year, > ordinal)` would be something to consider? Then of course implement that for > `Calendar.ISO`. > > > > On 5 Feb 2021, at 6:16 am, Christopher Keele <[email protected]> > wrote: > > Ordinal dates are interesting because while they are not calendar dates, > they are trivially convertible into them. > > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/BA38F710-E87F-436D-BDDA-CE76EB10447F%40gmail.com > <https://groups.google.com/d/msgid/elixir-lang-core/BA38F710-E87F-436D-BDDA-CE76EB10447F%40gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAGnRm4KUW9QCxquAPcMuvosV8e%3DM%2Bd0ReOEoBBY%2BTU%3DSQoKrUw%40mail.gmail.com.
