I think the pull request is a much better API. It both takes and returns a URI, and also gains type checking benefits (and readability benefits... single level of abstraction).
-bt On Fri, Nov 6, 2020 at 3:16 AM Andrea Leopardi <[email protected]> wrote: > Hey Spencer, > > Considering how concise the snippet of code you showed is even without > URI.encode_query/2, I think the value of having a smaller API surface is > higher than the value of adding a function that you can replace with just a > few more characters. Thoughts? > > On Thu, Nov 5, 2020 at 7:28 PM [email protected] < > [email protected]> wrote: > >> I would like to propose the addition of URI.encode_query/2 to the URI >> module to facilitate URI construction in a pipe friendly fashion. >> >> Here is an example MR on my fork of elixir >> https://github.com/spencerdcarlson/elixir/pull/2 >> >> -- >> You received this message because you are subscribed to the Google Groups >> "elixir-lang-core" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/elixir-lang-core/7e297574-b4d0-4b03-8279-4abe50c191e0n%40googlegroups.com >> <https://groups.google.com/d/msgid/elixir-lang-core/7e297574-b4d0-4b03-8279-4abe50c191e0n%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/CAM9Rf%2BKkTGR%3DG2bRApfhr51XD8RHr1HbZZg-Ef%3DJ8rb5aOOR5A%40mail.gmail.com > <https://groups.google.com/d/msgid/elixir-lang-core/CAM9Rf%2BKkTGR%3DG2bRApfhr51XD8RHr1HbZZg-Ef%3DJ8rb5aOOR5A%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Regards, Bruce Tate CEO <https://bowtie.mailbutler.io/tracking/hit/f8218219-d2a8-4de4-9fef-1cdde6e723f6/c7c97460-016e-45fb-a4ab-0a70318c7b97> Groxio, LLC. 512.799.9366 [email protected] grox.io -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAFXvW-4KRBnv3VLO3S6OSBSgLOHOKKohgee%3DqPo5ZZFxVfs1LA%40mail.gmail.com.
