Again, what's the problem with just silently supporting the basic form, exactly?
On Wed, Sep 11, 2019 at 10:23 PM Dmitry Belyaev <[email protected]> wrote: > Getting a value from a keyword definitely costs more then having that > value supplied directly as a positional argument. Of course the cost is > very small, but why waste when we have a way which doesn't waste. > > I suggest a separate function `from_iso8601_short`. > > On 9 September 2019 10:07:39 am AEST, Kelvin Raffael Stinghen < > [email protected]> wrote: >> >> > Another idea is to deprecate `Date.from_iso8601(string, calendar)` in >> favour of `Date.from_iso8601(string, calendar: calendar)`, and then >> `:format` becomes just another option. >> >> I’m +1 for this one. For optional parameters it is always good what >> actually that’s optional that it receives. I would even deprecate every >> `Date.something(date, calendar)` call in favor of that. >> >> Best, >> Kelvin Stinghen >> [email protected] >> >> On Sep 7, 2019, at 10:10, Wojtek Mach <[email protected]> wrote: >> >> Another idea is to deprecate `Date.from_iso8601(string, calendar)` in >> favour of `Date.from_iso8601(string, calendar: calendar)`, and then >> `:format` becomes just another option. >> >> >> > -- > Kind regards, > Dmitry Belyaev > > -- > You received this message because you are subscribed to the Google Groups > "elixir-lang-core" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/elixir-lang-core/DECB2A72-9D8E-45A7-BF0A-2FA52B7D9887%40gmail.com > <https://groups.google.com/d/msgid/elixir-lang-core/DECB2A72-9D8E-45A7-BF0A-2FA52B7D9887%40gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "elixir-lang-core" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/elixir-lang-core/CAKwTqE%3DnRA%2BBVnBKXnBWozzSg5BUzp5JJq4GVCdZ-bceEmYQfg%40mail.gmail.com.
