My bad, thanks for the clarification Wojtek!
Looking at other functions of the calendar types, it seems the calendar is
always passed as the last argument.
For reference, here are some functions with an input value, an option, and
a calendar as arguments:
- `DateTime.from_unix(integer, unit \\ :second, calendar \\
Calendar.ISO)`
- `NaiveDateTime.from_erl(tuple, microsecond \\ {0, 0}, calendar \\
Calendar.ISO)`
- `Time.from_erl(tuple, microsecond \\ {0, 0}, calendar \\ Calendar.ISO)`
I think Stefan's proposal is the closest one to the format of the current
function signatures.
On Sunday, September 8, 2019 at 8:41:01 PM UTC+2, Wojtek Mach wrote:
>
> But yes, I only showed Date.from_iso8601(string, calendar: calendar), I
> meant to say we’d make this change everywhere. Which also means there would
> be deprecations everywhere. Thanks for follow-up, this needed clarification.
--
You received this message because you are subscribed to the Google Groups
"elixir-lang-core" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/elixir-lang-core/a048b3dd-e161-4636-aba2-20256e2e749f%40googlegroups.com.
